feat: get a human readable pattern for a route #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sazarkin Sorry for taking this long. I guess nobody wanted to pick this up for Hacktoberfest 😄 Is this close to what you were looking for? This should allow you get the string representation of the route patterns. I've also added some pretty printers and used that to provide top level printers for utop. |
anuragsoni
force-pushed
the
print-route-pattern
branch
from
8d8b369 to
c25b0cb
Compare
|
The top level printers look like The string value can be accessed by the new functions added to the Routes module. |
|
Thanks a lot! |
anuragsoni
added a commit
to anuragsoni/opam-repository
that referenced
this pull request
Dec 18, 2019
CHANGES: * Improve mdx test tules (anuragsoni/routes#73, @NathanReb) * Use github actions instead of travis ci (anuragsoni/routes#70, anuragsoni/routes#72) * Get human readable route pattern from a route (anuragsoni/routes#64, anuragsoni/routes#74) * Allow writing custom path match patterns (anuragsoni/routes#76)
anuragsoni
added a commit
to anuragsoni/opam-repository
that referenced
this pull request
Dec 19, 2019
CHANGES: * Improve mdx test tules (anuragsoni/routes#73, @NathanReb) * Use github actions instead of travis ci (anuragsoni/routes#70, anuragsoni/routes#72) * Get human readable route pattern from a route (anuragsoni/routes#64, anuragsoni/routes#74) * Allow writing custom path match patterns (anuragsoni/routes#76)
anuragsoni
added a commit
to anuragsoni/opam-repository
that referenced
this pull request
Dec 20, 2019
CHANGES: * Improve mdx test tules (anuragsoni/routes#73, @NathanReb) * Use github actions instead of travis ci (anuragsoni/routes#70, anuragsoni/routes#72) * Get human readable route pattern from a route (anuragsoni/routes#64, anuragsoni/routes#74) * Allow writing custom path match patterns (anuragsoni/routes#76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #64